Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instagram Login/Registration #2562

Merged
merged 18 commits into from
Jul 18, 2017
Merged

Instagram Login/Registration #2562

merged 18 commits into from
Jul 18, 2017

Conversation

desaawa
Copy link
Contributor

@desaawa desaawa commented Jul 17, 2017 •
edited
Loading

This resolves #2559

Steps to test

  1. Register an app with Instagram at http://instagram.com/developer/clients/register
  2. Fill out the given form but make sure that redirect url as shown as follows-
    OAuth redirect_uri: <your-server-domain>:<port>/_oauth/instagram For example http://localhost:3000/_oauth/instagram
  3. After registration, copy the clientId and client secret.
  4. Signin to Reaction as admin
  5. On the dashboard, under Login Services, toggle on Instagram Sign In
  6. On a new browser, click on the authentication dropdown in nav and signin with instagram.

@desaawa desaawa changed the title [WIP] Instagram Login/Registration Instagram Login/Registration Jul 17, 2017
@kieckhafer kieckhafer requested review from kieckhafer and removed request for kieckhafer July 17, 2017 17:40
kieckhafer
kieckhafer requested changes Jul 17, 2017
View reviewed changes
Copy link
Member

@kieckhafer kieckhafer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reaction


Was Browser-Policy issue, has been fixed

kieckhafer
kieckhafer previously approved these changes Jul 17, 2017
View reviewed changes
@kieckhafer kieckhafer dismissed their stale review July 17, 2017 18:05

want another to look

@kieckhafer
Copy link
Member

account_profile

We get the users name from the Instagram API, can we use that to update the profile name so it shows their name instead of "Guest"?

@desaawa
Copy link
Contributor Author

desaawa commented Jul 17, 2017

@kieckhafer profile name now shows user's name from Instagram API.

kieckhafer
kieckhafer approved these changes Jul 17, 2017
View reviewed changes
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@brent-hoover
Copy link
Collaborator

brent-hoover commented Jul 18, 2017 •
edited
Loading

I'm using the App info that @kieckhafer posted in Slack and I get this error when I attempt to login:

{"error_type": "OAuthForbiddenException", "code": 403, "error_message": "You are not a sandbox user of this client"}

I tried creating another Instagram app but the instructions are not very complete

@kieckhafer
Copy link
Member

Looks like I need to add you to my App if you want to use the test creds I posted in the dev channel. Slack me your IG username and I'll add you if you want to use that App.

brent-hoover
brent-hoover approved these changes Jul 18, 2017
View reviewed changes
Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using @kieckhafer's app id (after getting added) and works great.

@brent-hoover brent-hoover merged commit 368a3d6 into development Jul 18, 2017
@brent-hoover brent-hoover deleted the awa-instagram-login/registration branch July 18, 2017 06:40
@brent-hoover brent-hoover mentioned this pull request Jul 18, 2017
Closed
jshimko added a commit that referenced this pull request Jul 18, 2017
@jshimko
Merge branch 'development' into register-component-api
a45c4c9 
* development:
  Instagram Login/Registration (#2562)
  Remove launchdock-connect files (#2570)
  Release 1.4.0 (#2558)
@spencern spencern mentioned this pull request Jul 21, 2017
Merged
@machikoyasuda machikoyasuda mentioned this pull request Jul 25, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brent-hoover brent-hoover brent-hoover approved these changes

@kieckhafer kieckhafer kieckhafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@desaawa @kieckhafer @brent-hoover